Instance handling refactor #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/pojlib/instance/MinecraftInstance.java # src/main/java/pojlib/util/CustomMods.java # src/main/java/pojlib/util/ModsJson.java
Novampr
pushed a commit
to Refitted-Team/Pojlib-HEF
that referenced
this pull request
Jun 21, 2024
* Add deletion, fix mod dir and default mods * Add javadocs (CAD get better at reading code) * Add supportedVersions.json * Fix Minecraft Version API * Handle xr errors * Fix race condition * Fix actions? * Slightly More Logging --------- Co-authored-by: The Judge <[email protected]> Co-authored-by: Darien Johnson <[email protected]>
thewiilover
pushed a commit
to thewiilover/Pojlib
that referenced
this pull request
Jun 24, 2024
* Add deletion, fix mod dir and default mods * Add javadocs (CAD get better at reading code) * Add supportedVersions.json * Fix Minecraft Version API * Handle xr errors * Fix race condition * Fix actions? * Slightly More Logging --------- Co-authored-by: The Judge <[email protected]> Co-authored-by: Darien Johnson <[email protected]>
CADIndie
added a commit
that referenced
this pull request
Oct 9, 2024
* Add deletion, fix mod dir and default mods * Add javadocs (CAD get better at reading code) * Add supportedVersions.json * Fix Minecraft Version API * Handle xr errors * Fix race condition * Fix actions? * Slightly More Logging --------- Co-authored-by: The Judge <[email protected]> Co-authored-by: Darien Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preamble: Were we high designing this the first time????
Separates mods into two categories, core mods and default mods. Default mods are used when NOT creating a instance for a modpack.
Rather than having a dedicated mods.json for mod handling we now use instances.json located in the game directory. It handles version related info + mods.
Since fabric allows us to configure where to find mods, search in the folder indicated at instance creation time, otherwise default to versionName.